[Ovirt-devel] Re: [PATCH] initial model work for lvm storage (revised2)

[Scott Seago]

Scott Seago wrote:
> This includes the model classes w/ migrations for the lvm storage pools and volumes, and some changes required to support Storage Volume tasks. This patch does not include all of the necessary model API methods to support lvm, but it's a starting point -- some changes to clalance's taskomatic bits will be required to support this, and we will need additional model enhancements when the UI work is done, and when the taskomatic back end is finalized.
>
> revised to fix a couple controller bugs and to increment the migration version #
> and to fix some additional model problems in taskomatic and host-status
>
> Signed-off-by: Scott Seago <sseago at redhat.com>
> ---
>  src/app/controllers/host_controller.rb             |    8 +-
>  src/app/controllers/storage_controller.rb          |   35 ++-----
>  src/app/controllers/vm_controller.rb               |   34 +++---
>  src/app/models/host.rb                             |    2 +-
>  src/app/models/host_task.rb                        |   11 ++-
>  src/app/models/iscsi_storage_pool.rb               |    2 +-
>  .../models/{host_task.rb => lvm_storage_pool.rb}   |   30 ++++--
>  .../{nfs_storage_pool.rb => lvm_storage_volume.rb} |   12 +--
>  src/app/models/nfs_storage_pool.rb                 |    2 +-
>  src/app/models/storage_pool.rb                     |   12 ++-
>  src/app/models/storage_task.rb                     |   11 ++-
>  src/app/models/storage_volume.rb                   |   15 +++-
>  .../{host_task.rb => storage_volume_task.rb}       |   22 +++-
>  src/app/models/task.rb                             |   15 ++-
>  src/app/models/vm.rb                               |   12 +-
>  src/app/models/vm_task.rb                          |   15 ++-
>  src/db/migrate/025_add_lvm_storage.rb              |  106 ++++++++++++++++++++
>  src/dutils/active_record_env.rb                    |    2 +
>  src/host-status/host-status.rb                     |    5 +-
>  src/task-omatic/task_host.rb                       |    2 +-
>  src/task-omatic/task_storage.rb                    |    4 +-
>  src/task-omatic/task_vm.rb                         |   48 +++------
>  src/test/fixtures/tasks.yml                        |   32 ++++--
>  23 files changed, 296 insertions(+), 141 deletions(-)
>  copy src/app/models/{host_task.rb => lvm_storage_pool.rb} (62%)
>  copy src/app/models/{nfs_storage_pool.rb => lvm_storage_volume.rb} (82%)
>  copy src/app/models/{host_task.rb => storage_volume_task.rb} (69%)
>  create mode 100644 src/db/migrate/025_add_lvm_storage.rb
>   

I pushed this today. The only thing lacking for the ACK from clalance 
was further testing after I fixed the problems found earlier. I fixed 
these and tested creating storage pools as well as 
creating/stopping/starting VMs.

Scott