[Ovirt-devel] How to handle 3rd party code?

[Darryl Pierce]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Scott Seago wrote:
>> I think the best solution would be to keep their code out of our
>> repository and instead package them as separate RPMs and then depend on
>> them from ours. As an example, look at how we require rubygem-cobbler
>> and rubygem-activeldap. Neither is kept in our repository.
>>
>> How many dependencies do we have?
>>
>>   
> The difficulty here is that we're not talking about the sort of reusable
> components that just need to be installed in a standard location and
> added to the right search path (as is the case with rubygem-cobbler).
> We've got javascript files that need to be included in
> /usr/share/ovirt-server/public/javascript and the plugin code that needs
> to be installed under /usr/share/ovirt-server/vendor/plugins.
> 
> We _could_ package them as separate RPMs but the dependencies would be
> messy -- since they must live under the app root they would depend on
> ovirt-server, but since ovirt-server needs them, then the dependency
> needs to go the other way.
> 
> So what we have here is a collection of code from different sources that
> actually forms part of our app. On top of that we have some
> ovirt-specific customizations to the javascript libraries which does
> need to live in our repo.

So, in that case, isn't the solution still a separate RPM but one that's
specific to our product? IOW, if there's a javascript package called
"foo", then we would potentially have a foo.rpm and a foo-ovirt.rpm that
would apply any patches we have to customize it to our need?

I guess what I'm getting at is more about keeping third party code out
of our repo as much as possible. Unless we're freezing on a specific
snapshot of their code, we should avoid having to version their code. We
had done that in a previous project and it was just a bear to deal with.

- --
Darryl L. Pierce <dpierce at redhat.com> : GPG KEYID: 6C4E7F1B
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkkApUgACgkQjaT4DmxOfxtQeQCgqACjjaGo+VOcKsQry25pv9jv
BYoAn27b66oIYrhG6Tx05hsgMHqsMI9u
=KyBi
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dpierce.vcf
Type: text/x-vcard
Size: 319 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20081023/98460b9a/attachment.vcf>