[Ovirt-devel] Re: [PATCH server] network integration into ovirt server db and wui

[Mohammed Morsi]

Hugh O. Brock wrote:
> On Fri, Oct 31, 2008 at 11:35:36AM -0400, Mohammed Morsi wrote:
>   
>> Based on Darryl's, Scott's, and Dan's feedback on my patch, the
>> following things have been identified as needing to be done for the
>> network component of the interface. I'm not sure all of this will be
>> able to be done by the end of today (unless I can get some development
>> help) so this list will need to be prioritized:
>>
>> 1. Remove 'validate' method, replace w/ 'validates_presence_of',
>> 'validate_format_of' where we can
>>     
I can take care of this bit

>> 2. Change ManageNodeConfiguration bit, to use new network model / schema
>>     
The only thing this depends on is the model changes I did, which was
based on http://www.ovirt.org/page/Redesigned_Network_Configuration. If
someone who knows this bit more that I do can take care of it, it would
speed things up

>> 3. Disable type selection for 'edit network' form
>>     
Small, quick fix that I can take care of

>> 4. Associate vlan w/ physical_network, eg add parent_network_id to
>> network table, allow this to be specified via new / edit network form
>> (only for vlans)
>>     
>From what I gather, this is important, but not critical for this patch.
This probably can be taken care of with a followup / bug-fix patch next
week.

>> 5. Add ip address information to the network details pane
>> 6. Add nic / bonding information to host details pane
>>     
Both these items should be fairly straightforward and I can take care of.

>> 7. VLANs should be associated with nics as well (seemingly small, but
>> potentially large change)
>>     
Once again, I'm seeing this as important but can wait till the follow up
patch next week, correct?

>> 8. Add usages multi-select box to create / edit network form
>>     
Another straightforward item I can take care of

>> 9. Remove 'add / edit networks' link from dashboard, use tabs
>>     
Shouldn't be too hard, but low on priority in lieu of the other items,
so if anyone wants to grab this feel free, otherwise it might not get in
today.

>> 10. Add 'add / remove nics' functionality and interface
>>     
This is incorrect and should no longer be on this list.

>> 11. Small cleanup fixes
>>     
There are a few specific things as pointed out by Darryl and Scott, in
addition to things that can just be taken as they are come accross.

>> From what I see / heard, numbers 2,3, 8 are must-haves, eg my patch
>> can't be pushed w/ out these. The others, as important as they are, can
>> wait for a subsequent bug fix patch. What do you all think, taking into
>> consideration that we want this pushed by the end of today.
>>     
>
> Jay and Scott, can you guys lend a hand and get this patch wrapped
> today? I don't know if the work can be partitioned among 3, what do
> you think?
>
> Thanks,
> --Hugh
>   

Thanks for the help everyone,
    -Mo