[Ovirt-devel] [PATCH appliance] autoconfiscate

[Jim Meyering]

"Daniel P. Berrange" <berrange at redhat.com> wrote:

> On Thu, Sep 11, 2008 at 03:55:41PM +0200, Jim Meyering wrote:
>> "Daniel P. Berrange" <berrange at redhat.com> wrote:
>> > On Thu, Sep 11, 2008 at 03:46:38PM +0200, Jim Meyering wrote:
>> >>
>> >> release.mk: Copy from ../node
>> >> autogen.sh: Likewise.
>> >> Makefile.am: New file.  List distributed files.
>> >> configure.ac: Set package name.
>> >
>> > ACK, this is a good start. I'd like to it an add on though
>> > that removes all  the junk from the RPM %install section
>> > and puts it into the Makefile, you can just do 'make install'.
>> > RPM build scripts should be for distro integration only,
>> > not a core part of the generic application build & install
>> > process. I notice the ovirt-node suffers from the same problem
>>
>> I agree.
>> I'm taking small steps and didn't have a lot of time for this today.
>> Now that I have usable hardware+F9, I'm looking at SElinux.
>> How about if I push this for now, and save the further
>> (and required, "proper") integration for later.
>
> Yes - no problem - any step in the right direction is  worthwhile change
> to apply.

Pushed it.