[Ovirt-devel] Re: [PATCH] added ability to reprovision vm via edit vm form

[Chris Lalancette]

Scott Seago wrote:
> Yeah -- we need to do them in the same place. As it is with this patch, 
> there's a bit of a race condition if you edit a vm right after creating 
> (but before taskomatic executes create_vm). Originally I'd made the 
> decision to put the system create in taskomatic, since that's where all 
> the other action-oriented bits that call out to external servers are 
> handled. It's probably not that big a deal either way though, as we're 
> already making cobbler calls from the WUI to get the profile list.
> 
> But yes, we need to either put both of these calls in taskomatic or gut 
> create_vm and put both in the WUI. My original preference here was for 
> taskomatic to handle it, but the reprovision case makes that much more 
> complex (since we'd need a new task type, etc), so maybe it makes more 
> sense to do it all in the WUI.
> 
> Any other opinions on this?

Not an opinion (since I don't really care where it's done, as long as it is
consistent), but a fact: in theory the cobbler stuff could hang up the WUI if
there are network issues.  If you do something like:

iptables -A INPUT -p tcp --dport <cobbler_port> -j DROP

on the cobbler server to simulate a network outage, then try to connect to it
remotely, you will hang up for quite a while TCP attempts to connect.  It's one
reason to slightly prefer taskomatic to do it, but it may not be compelling
enough.  I just thought I would point it out.

-- 
Chris Lalancette