[Ovirt-devel] Re: [PATCH node] add ovirt semodule in Node

[Alan Pevec]

Perry Myers wrote:
> FIXME: This patch is going in to fix the problem, but we should be using
> http://fedoraproject.org/wiki/PackagingDrafts/SELinux/PolicyModules
yes, +1 for this FIXME

WS-only changes as separate NFS commit
> -	|| echo "$string" >> "$file"
> +        || echo "$string" >> "$file"
> -	exit 2
> +        exit 2

> +
> +# Common to both stateless and stateful Nodes
> +
> +if $(selinuxenabled) ; then

no need to subshell:
if selinuxenabled ; then

> +    # make disks available to VMs
> +    cat > /tmp/ovirt.te <<EOF

as Jim mentioned, <<\EOF to ease sore reviewer eyes :)

ACK otherwise