[Ovirt-devel] [PATCH ovirt-node-image] do not require SELinux build host if disabled in kickstart

[Jim Meyering]

Alan Pevec <apevec at redhat.com> wrote:
> Jim Meyering wrote:
>> Probably won't ever matter, but...
>> you could add '^[[:space:]]', in case there's ever leading spaces,
>> it's #-commented (if ksflatten doesn't eliminate those), or that string
>> happens to occur within some other construct, like a grep argument ;-)
>
> yes, ksflatten eliminates all comments and produces canonical output, so changing regexp to:
> '^selinux --disabled$'

>>> +              setenforce \$enforcing 2>/dev/null"
>>
>> I'd prefer not to discard setenforce diagnostics, and to run it only
>> if necessary, so how about invoking it only when $enforcing is 1 ?
>>
>>               test x\$enforcing = x1 && setenforce 1"
>
> applied, thanks
>
> From ae098b5f49f2158e0029cb95a48c943414d1b551 Mon Sep 17 00:00:00 2001
> From: Alan Pevec <apevec at redhat.com>
> Date: Tue, 23 Sep 2008 19:21:14 +0200
> Subject: [PATCH ovirt-node-image] do not require SELinux enabled build host if disabled in kickstart

I like the added '$', too ;-)
ACK