[Ovirt-devel] [PATCH node] The node now passes in the mac address and iface names during identify.

[Perry N. Myers]

Daniel P. Berrange wrote:
> On Tue, Sep 23, 2008 at 12:34:32PM -0400, Perry N. Myers wrote:
>> Daniel P. Berrange wrote:
>>> On Tue, Sep 23, 2008 at 12:10:22PM -0400, Perry N. Myers wrote:
>>>> Daniel P. Berrange wrote:
>>>>> On Tue, Sep 23, 2008 at 01:18:30PM +0100, Daniel P. Berrange wrote:
>>> Messaging isn't going to help us in standalone mode. We need to have any
>>> augtool scripts or bash scripts in the node image, not fetched over
>>> messaging or wget. So we have to fix this to only fetch config settings
>>> regardless of whether we currently use messaging or not.
>> Agreed.  As I said above, lets just get this patch in now since we're no 
>> worse off than before and since we're trying to get a release out.  But we 
>> do need to fix this so that only config parameters are retrieved and not 
>> augtool scripts themselves.
> 
> Yep, I'm fine with that - I didn't realize this was already merged.
> 
>> That fix can come separately from the messaging integration depending on 
>> how timing works out for that.
> 
> After discussing this on IRC one thing became clear - we would be helped
> by writing down some of the architectural / design requirements & guidelines
> we have for the node to help people choose effective implementation strategy.
> At first review it wasn't clear that Darryl's initial impl was a problem.
> 
> As a starting point, I'd suggest a HACKING file containing guidelines
> for development. One such pertinent entry is
> 
>  - All functional logic has to be contained in the node image itself.
>    This includes shell scripts, program, augeus scripts. Only configuration
>    data can be fetched from a remote source.
> 
>    This ensures there is only a 1-way dependanancy from the WUI server
>    to the node server, and not have the node depend on the WUI. This
>    is important for upgradability. It also enables the node image to run
>    in standalone mode storing config data locally.
> 
>    NB, we're assuming there's also secure bootstrap mechansim for getting
>    the kerberos credential onto the machine.

Agreed and this is a good start for the hacking file.

Perry