[Ovirt-devel] Re: : Minor cleanup of DEBUG statements in ovirt-identify-node

Darryl L. Pierce dpierce at redhat.com
Tue Sep 2 12:54:27 UTC 2008


+++ Chris Lalancette [02/09/08 10:37 +0200]:
>    Minor cleanup of the DEBUG print statements in ovirt-identify-node.
>    
>    Signed-off-by: Chris Lalancette <clalance at redhat.com>
>
>diff --git a/ovirt-managed-node/ovirt-identify-node/comm.c b/ovirt-managed-node/ovirt-identify-node/comm.c
>index 16dc3b8..ee5e174 100644
>--- a/ovirt-managed-node/ovirt-identify-node/comm.c
>+++ b/ovirt-managed-node/ovirt-identify-node/comm.c
>@@ -35,14 +35,14 @@ saferead(int fd, char *buf, size_t count)
> 
>     len_left = count;
> 
>-    DEBUG("Begin saferead(%d, %p, %d)\n", fd, buf, count);
>+    DEBUG("Begin saferead(%d, %p, %zd)\n", fd, buf, count);
> 
>     while (!done) {
>         DEBUG("Before read(%d,%p,%d)\n", fd, buf + offset, len_left);
> 
>         bytes = read(fd, buf + offset, len_left);
> 
>-        DEBUG("After read: bytes=%d\n", bytes);
>+        DEBUG("After read: bytes=%zd\n", bytes);
> 
>         if (bytes == 0) {
>             done = 1;
>@@ -56,7 +56,7 @@ saferead(int fd, char *buf, size_t count)
>             done = 1;
>         }
> 
>-        DEBUG("End of decision loop: offset=%d, len_left=%dl, done=%d\n",
>+        DEBUG("End of decision loop: offset=%zd, len_left=%dl, done=%d\n",
>               offset, len_left, done);
>     }
> 

ACK.

-- 
Darryl L. Pierce, Sr. Software Engineer
Red Hat, Inc. - http://www.redhat.com/
oVirt - Virtual Machine Management - http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080902/7a12aa5c/attachment.sig>


More information about the ovirt-devel mailing list