[Ovirt-devel] work around "*** ERROR: No build ID note found in..." on rawhide
Daniel P. Berrange
berrange at redhat.com
Mon Sep 8 12:41:19 UTC 2008
On Mon, Sep 08, 2008 at 02:32:03PM +0200, Jim Meyering wrote:
> On Friday, I got this:
>
> *** ERROR: No build ID note found in /ov/node/rpm-build/BUILDROOT/ovirt-node-0.92-1.fc10.x86_64/usr/sbin/ovirt-identify-node
> --- a/ovirt-identify-node/Makefile
> +++ b/Makefile.am
> @@ -1,5 +1,4 @@
> # Copyright (C) 2008 Red Hat, Inc.
> -# Written by Darryl L. Pierce <dpierce at redhat.com>
> #
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> @@ -16,23 +15,33 @@
> # MA 02110-1301, USA. A copy of the GNU General Public License is
> # also available at http://www.gnu.org/copyleft/gpl.html.
>
> -CC=gcc
> -CFLAGS=-Wall -c -g $(shell pkg-config --cflags dbus-1)
> -LFLAGS=-lhal -lvirt
> -OBJECTS=comm.o gather.o hal_support.o main.o protocol.o
> -TARGET=ovirt-identify-node
> -SOURCES=\
> - ovirt-identify-node.c
> +SUBDIRS = ovirt-identify-node
>
> -all: $(TARGET)
> +EXTRA_DIST = \
> + .gitignore \
> + ovirt-node.spec \
> + release.mk \
> + version \
> + scripts/collectd \
> + scripts/collectd.conf.in \
> + scripts/dhclient-exit-hooks \
> + scripts/kvm-ifup \
> + scripts/ovirt \
> + scripts/ovirt-awake \
> + scripts/ovirt-early \
> + scripts/ovirt-functions \
> + scripts/ovirt-post \
> + logrotate/ovirt-logrotate \
> + logrotate/ovirt-logrotate.conf
>
> -.c.o:
> - $(CC) $(CFLAGS) $< -o $@
> +include release.mk
>
> -clean:
> - rm -rf $(OBJECTS) $(TARGET)
> -
> -$(TARGET): $(OBJECTS)
> - $(CC) -o $@ $(OBJECTS) $(LFLAGS)
> -
> -.PHONY: all clean
> +pkg_name = ovirt-node
> +.PHONY: tar
> +tar: dist
> + tar xf $(distdir).tar.gz
> + mkdir -p rpm-build/BUILDROOT
> + tar zcvf rpm-build/$(NV).tar.gz $(NV)
> + cp version rpm-build
> + chmod -R u+rwx $(NV)
> + rm -rf $(NV)
Do we really need to preserve this custom target when automake
provides a perfectly good 'make dist'. It just seems to be taking
the tar.gz, extracting it, and then re-creating it with files having
a rpm-build/ prefix which is just wierd. RPMs should be built from
the real tar.gz automake provides.
> diff --git a/autogen.sh b/autogen.sh
> --- /dev/null
> +++ b/configure.ac
> @@ -0,0 +1,13 @@
> +# FIXME: version
> +AC_INIT([ovirt-node], [0.1], [ovirt-devel at redhat.com])
> +AM_INIT_AUTOMAKE([-Wall -Werror foreign])
> +AC_PROG_CC
> +AC_CONFIG_HEADERS([config.h])
> +
> +# for ovirt-identify-node
> +PKG_CHECK_MODULES([DBUS], [dbus-1])
> +PKG_CHECK_MODULES([HAL], [hal])
> +PKG_CHECK_MODULES([VIRT], [libvirt])
Should check for minimum required versions really - I'm sure there's
a minimal libvirt you need. If you don't know what version of DBus
or HAL is required, then pick one from F9 and we can tweak it later
eg,
PKG_CHECK_MODULES([VIRT], [libvirt >= 0.4.4])
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the ovirt-devel
mailing list