[Ovirt-devel] [PATCH] Added additional fields to the nic table.

[Darryl L. Pierce]

----- "Perry N. Myers" <pmyers at redhat.com> wrote:

> Darryl L. Pierce wrote:
> > The new fields are netmask and broadcast.
> > 
> > You will need to run a migration with this patch.
> 
> I'm not the right one to give ACKs on object model changes in the DB,
> but 
> this looks ok with one question...
> 
> How does the administrator indicate that a given NIC should be
> configured 
> via DHCP?  Is this done by explicitly setting the IP_ADDRESS field?

The upcoming configuration generator patch addresses this. I had initially set a "use_dhcp" column, but have refactored that, based on this feedback. Now there's a boot_types table that contains the list of boot types: bootp, dhcp and static. The nics table ties to that and the generator uses that information to decide whether to send down a static IP configuration or a bootproto.

-- 
Darryl L. Pierce, Sr. Software Engineer
Red Hat, Inc. - http://www.redhat.com/
oVirt - Virtual Machine Management - http://www.ovirt.org/
"What do you care what other people think, Mr. Feynman?"