[Ovirt-devel] [PATCH ovirt-node-image] do not require SELinux build host if disabled in kickstart

[Alan Pevec]

Jim Meyering wrote:
> Probably won't ever matter, but...
> you could add '^[[:space:]]', in case there's ever leading spaces,
> it's #-commented (if ksflatten doesn't eliminate those), or that string
> happens to occur within some other construct, like a grep argument ;-)

yes, ksflatten eliminates all comments and produces canonical output, so changing regexp to:
'^selinux --disabled$'

>> +              setenforce \$enforcing 2>/dev/null"
> 
> I'd prefer not to discard setenforce diagnostics, and to run it only
> if necessary, so how about invoking it only when $enforcing is 1 ?
> 
>               test x\$enforcing = x1 && setenforce 1"

applied, thanks

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-do-not-require-SELinux-enabled-build-host-if-disable.patch
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080923/d08d8ce4/attachment.ksh>