[Ovirt-devel] [PATCH server] Fixes to the managed_node_configuration code.

[Darryl L. Pierce]

On Tue, Mar 31, 2009 at 08:17:44PM -0400, Mohammed Morsi wrote:
> > -      result.puts "#{entry}|ONBOOT=yes"
> > +      add_bridge(result,
> > +                 "none",
> > +                 bonding.interface_name,
> > +                 (bonding.ip_addresses.empty? ? "dhcp" : "static"),
> > +                 (bonding.ip_addresses.empty? ? nil : bonding.ip_addresses[0]))
> >  
> >   
> Are you sure bonding bridges don't need to have an assigned mac address?

Yes, I'm certain:

8.  Where does a bonding device get its MAC address from?

If not explicitly configured with ifconfig, the MAC address of the bonding device is 
taken from its first slave device. This MAC address is then passed to all following 
slaves and remains persistent (even if the the first slave is removed) until the 
bonding device is brought down or reconfigured.

http://www.kernel.org/pub/linux/kernel/people/marcelo/linux-2.4/Documentation/networking/bonding.txt

Applying your other comments. Updated patch to follow.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090401/8f53ca52/attachment.sig>