[Ovirt-devel] [PATCH server] First step of detail pane UI cleanup.

[Mohammed Morsi]

Looks good, so ACK, with a comment below.

Jason Guiditta wrote:
> This patch implements layout fixes to clean up look of the
> details pane throughout the site, so it looks more like
> the design here:
> http://ovirt.org/page/Summary_UX
>
> Note that this does not include the actual rearrangement of
> Hardware Pools summary pages.  Best place to see changes is
> on the summary for a Resource Pool.
> ---
>  src/app/views/layouts/selection.rhtml       |   15 +++++++++------
>  src/app/views/resources/quick_summary.rhtml |    6 ++----
>  src/public/stylesheets/components.css       |   11 +++++++----
>  src/public/stylesheets/layout.css           |   11 +++--------
>  4 files changed, 21 insertions(+), 22 deletions(-)
>
> diff --git a/src/app/views/layouts/selection.rhtml b/src/app/views/layouts/selection.rhtml
> index e7aefc2..1f313d7 100644
> --- a/src/app/views/layouts/selection.rhtml
> +++ b/src/app/views/layouts/selection.rhtml
> @@ -1,8 +1,11 @@
> -<div class="selection_left">
> -  <div class="selection_title"><%= yield :title -%></div>
> +<div class="selection_title"><%= yield :title -%></div>
>  
>    <% tools = yield :action_links -%> 
>    <% if tools %>
> +<!-- FIXME: for the love of pete, are we really using a list just to insert a separator??
> +     This needs to be cleaned up as soon as somone has time.  It should be a horizontal list
> +     for the links (tools), with this separator set as a left background on the first item.
> +-->
>   
Does it being a list break anything specifically? I think a list is
fine, we're not only using it for a separator but we're styling it in
the css to appear horizontal / have the same effect you described. We'd
need the same css for the divs if we we're to remove the list plus the
exception for the first. So not sure if this comment should go in.


Other than that, the patch looks good, the details pane output looks
just like Jeremy's screenshot.

    -Mo