[Ovirt-devel] [PATCH server] first round of permissions refactoring.

Jason Guiditta jguiditt at redhat.com
Tue Apr 14 18:56:09 UTC 2009


ACK, one super-minor nit inline.

-j

On Mon, 2009-03-30 at 19:08 +0000, Scott Seago wrote:
> diff --git a/src/db/migrate/037_add_roles_and_privileges.rb b/src/db/migrate/037_add_roles_and_privileges.rb
> new file mode 100644
> index 0000000..322014e
> --- /dev/null
> +++ b/src/db/migrate/037_add_roles_and_privileges.rb
> @@ -0,0 +1,119 @@

> +class AddRolesAndPrivileges < ActiveRecord::Migration
> +  def self.up
> +#    create_table :permissions do |t|
> +#      t.string  :user_role
> +#      t.string  :user
> +#      t.integer :pool_id
> +#      t.integer :inherited_from_id
> +#      t.integer :lock_version, :default => 0
> +#    end

Unless there is a reason to keep the above, could you delete it rather
than commenting out?

> +    create_table :roles do |t|




More information about the ovirt-devel mailing list