[Ovirt-devel] Re: [PATCH server] allow admin to setup iptables port forwarding on server for a vm's vnc port

Mohammed Morsi mmorsi at redhat.com
Wed Feb 4 04:14:57 UTC 2009


David Lutterkort wrote:
> ...
> ACK from reading over it, with one nit:
>
>   
> ...
> The 'collect' should just be an 'each', and you can replace the 'return
> i' with a 'break', since you don't care about the result of the block,
> only its sideeffects.
>
> David
>
>
>   


Made the changes and pushed both the viewer and server code to the repo.
Appreciate all the help.


     -Mo




More information about the ovirt-devel mailing list