[Ovirt-devel] Re: [PATCH node] ovirt_store_config: return error code

[Alan Pevec]

Alan Pevec wrote:
>                  && mount -n --bind /config$f $f \
>                  || printf " Failed to persist\n"
>                  printf " File persisted\n"
> +                rc=1

this is, of course, wrong, correct is:
-                && mount -n --bind /config$f $f \
-                || printf " Failed to persist\n"
-                printf " File persisted\n"
+                && mount -n --bind /config$f $f
+                if [ $? -ne 0 ]; then
+                    printf " Failed to persist\n"
+                    rc=1
+                else
+                    printf " File persisted\n"
+                fi