[Ovirt-devel] [PATCH node] Fixes the messages after running any configuration option.

Darryl L. Pierce dpierce at redhat.com
Mon Feb 23 22:00:14 UTC 2009


Previously, if any script had a 0 return code, o-c-setup would say it
ran successfully. This was confusing, especially when the user aborted.
So now o-c-setup shows nothing until the script exited with a non-zero
error code. All scripts already reported success, failure and abort
messages, so no other changes were really needed.

Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
---
 scripts/ovirt-config-setup   |    2 +-
 scripts/ovirt-config-storage |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/ovirt-config-setup b/scripts/ovirt-config-setup
index 4fcc212..69b279b 100755
--- a/scripts/ovirt-config-setup
+++ b/scripts/ovirt-config-setup
@@ -42,7 +42,7 @@ while true; do
                     clear;
                     {
                         if $CONFIG_DIR/*"$OPTION" ; then
-                            printf "\n$OPTION Completed Successfully\n\n"
+                            printf "\n"
                         else
                             printf "\nERROR: $OPTION FAILED. "
                             printf "See $OVIRT_LOGFILE\n\n"
diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index c29f99c..18b9e0c 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -503,7 +503,7 @@ else
                 "Configure") do_configure ; break ;;
                 "Review")    do_review    ; break ;;
                 "Partition") do_confirm   ; break ;;
-                "Quit")      exit ;;
+                "Quit")      printf "\nExiting.\n"; exit ;;
             esac
         done
     done
-- 
1.6.0.6




More information about the ovirt-devel mailing list