[Ovirt-devel] [PATCH node] Added a wrapper script around the boot menu item to describe
Bryan Kearney
bkearney at redhat.com
Thu Jan 15 14:39:24 UTC 2009
This is a resend of the earlier patch. Based on discussions on the list, there
is enough boundary condition testing, but we added a stronger reminder
to do all the configuration before reboot.
-- bk
---
Makefile.am | 1 +
ovirt-node.spec.in | 4 +++-
scripts/ovirt-config-boot-wrapper | 21 +++++++++++++++++++++
3 files changed, 25 insertions(+), 1 deletions(-)
create mode 100755 scripts/ovirt-config-boot-wrapper
diff --git a/Makefile.am b/Makefile.am
index 6847234..c62774f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -30,6 +30,7 @@ EXTRA_DIST = \
scripts/ovirt \
scripts/ovirt-awake \
scripts/ovirt-config-boot \
+ scripts/ovirt-config-boot-wrapper \
scripts/ovirt-config-hostname \
scripts/ovirt-config-logging \
scripts/ovirt-config-networking \
diff --git a/ovirt-node.spec.in b/ovirt-node.spec.in
index 501bf4f..f30dd62 100644
--- a/ovirt-node.spec.in
+++ b/ovirt-node.spec.in
@@ -132,6 +132,7 @@ cd -
%{__install} -p -m0755 scripts/ovirt-awake %{buildroot}%{_sbindir}
%{__install} -p -m0755 scripts/ovirt-config-boot %{buildroot}%{_sbindir}
+%{__install} -p -m0755 scripts/ovirt-config-boot-wrapper %{buildroot}%{_sbindir}
%{__install} -p -m0755 scripts/ovirt-config-hostname %{buildroot}%{_sbindir}
%{__install} -p -m0755 scripts/ovirt-config-logging %{buildroot}%{_sbindir}
%{__install} -p -m0755 scripts/ovirt-config-networking %{buildroot}%{_sbindir}
@@ -191,7 +192,7 @@ install -p -m 644 images/syslinux-vesa-splash.jpg %{buildroot}/usr/lib/anaconda-
%{__ln_s} ../..%{_sbindir}/ovirt-config-networking %{buildroot}%{_sysconfdir}/ovirt-config-setup.d/"15_Networking Setup"
%{__ln_s} ../..%{_sbindir}/ovirt-config-storage %{buildroot}%{_sysconfdir}/ovirt-config-setup.d/"20_Disk Partitioning"
%{__ln_s} ../..%{_sbindir}/ovirt-config-logging %{buildroot}%{_sysconfdir}/ovirt-config-setup.d/"30_Logging Setup"
-%{__ln_s} ../..%{_sbindir}/ovirt-config-boot %{buildroot}%{_sysconfdir}/ovirt-config-setup.d/"99_Local install and reboot"
+%{__ln_s} ../..%{_sbindir}/ovirt-config-boot-wrapper %{buildroot}%{_sysconfdir}/ovirt-config-setup.d/"99_Local install and reboot"
%clean
@@ -253,6 +254,7 @@ fi
%defattr(-,root,root,0755)
%{_sbindir}/ovirt-awake
%{_sbindir}/ovirt-config-boot
+%{_sbindir}/ovirt-config-boot-wrapper
%{_sbindir}/ovirt-config-hostname
%{_sbindir}/ovirt-config-logging
%{_sbindir}/ovirt-config-networking
diff --git a/scripts/ovirt-config-boot-wrapper b/scripts/ovirt-config-boot-wrapper
new file mode 100755
index 0000000..d223599
--- /dev/null
+++ b/scripts/ovirt-config-boot-wrapper
@@ -0,0 +1,21 @@
+#!/bin/bash
+#
+# Wrapper function to make sure the user wishes to continue before
+# rebooting the system
+
+while true; do
+ printf "\nThis option will exit the menu, and require a reboot. \n\
+Please ensure that you have configured the local storage \n\
+and networking correctly on the previous menu before \n\
+continuing."
+ printf "\n\n"
+ read -p "Do you wish to continue? (Y|N)? "
+ r=$(echo $REPLY|tr '[[:lower:]]' '[[:upper:]]')
+ if [ "$r" == "Y" ]; then
+ /usr/sbin/ovirt-config-boot
+ break
+ elif [ "$r" == "N" ]; then
+ printf "\nExiting back to the menu\n"
+ break
+ fi
+done
--
1.6.0.6
More information about the ovirt-devel
mailing list