[Ovirt-devel] Re: [PATCH node] Reworked logging for standalone mode

[Alan Pevec]

Perry Myers wrote:
> Entire firstboot is logged to both console/logfile using tee.  Selected
> sections of the code are set to only log stdout/stderr to logfile to prevent
> data overload on console.  In these cases log() function is used to write
> to the console.

ACK just minor whitespace nits, which I'll fix and push

> @@ -297,7 +310,7 @@ do_confirm()
>              Y|y)
>                  check_partition_sizes
>                  perform_partitioning
> -		exit 0
> +		        exit 0

whitespace damage - and it's changed in "Checks the request partitions" anyway

> -                "Quit")      exit ;;
> +                "Quit") exit ;;

same here

> @@ -220,15 +253,16 @@ mount_logging() {
>      fi
>  
>      if [ -e /dev/HostVG/Logging ] ; then
> +        log "Mounting log partition"
>          #  backup the logs
>          if [ -e /var/log.bak ]; then
>              rm -rf /var/log.bak
>          fi
> -        cp -a /var/log /var/log.bak
> +        cp -av /var/log /var/log.bak
>  
>          mount /dev/HostVG/Logging /var/log
>          restorecon -rv /var/log

move to after cp, just in case

> -        mv /var/log.bak/* /var/log
> +        cp -av /var/log.bak/* /var/log
>          rm -Rf /var/log.bak
>          service rsyslog restart