[Ovirt-devel] [PATCH node] Bump log rotation so logs can be up to 1MB for standalone mode

[Jim Meyering]

Perry Myers <pmyers at redhat.com> wrote:
> 10k is a good default size for a completely stateless node, but in standalone
> mode or when we have local storage available we should use more of it for logs
>
> For ovirt-server managed mode, making max log size 1MB won't affect overall
> memory usage too badly.  With ~10 log files, the max disk usage will be about
> 10MB

ACK, w/suggestion

> diff --git a/scripts/ovirt-functions b/scripts/ovirt-functions
> index 13f9ad4..2e62fc4 100644
> --- a/scripts/ovirt-functions
> +++ b/scripts/ovirt-functions
> @@ -27,7 +27,8 @@ OVIRT_CONFIG_FILES="\
>   /etc/ssh/ssh_host*_key* \
>   /etc/default/ovirt \
>   /etc/sysconfig/network \
> - /etc/collectd.conf
> + /etc/collectd.conf \
> + /etc/logrotate.d/ovirt-logrotate.conf

As someone who recently made the mistake of omitting backslashes
in a list just like that (it was in a libvirt Makefile), I feel
obliged to suggest aligning them.  Then it's harder for people
like me to make the mistake ;-)

    /etc/ssh/ssh_host*_key*			\
    /etc/default/ovirt				\
    /etc/sysconfig/network 			\
    /etc/collectd.conf				\
    /etc/logrotate.d/ovirt-logrotate.conf