[Ovirt-devel] Re: [PATCH node] Reworked logging for standalone mode

Alan Pevec apevec at redhat.com
Sun Jan 18 16:23:22 UTC 2009


Jim Meyering wrote:
> E.g., you could test $LOG_STATUS != 1 in start_log,
> since there are two tests of $LOG_STATUS = 1 already.
> Or maybe you prefer "boolean" semantics and would
> want to test against 0.

yes, boolean is more, err, logical :)
 
> All names defined/used above impinge on the name space
> of each script that sources ovirt-functions, so it'd be
> nice to use names that make collisions less likely e.g.,
> _TEE, _log and $_LOG_STATUS.

agreed for _log_status, that's ovirt-functions internal
but TEE and log are public so I kept them with the remark that scripts should not redefine them




More information about the ovirt-devel mailing list