[Ovirt-devel] [PATCH server] Create VM/Storage integration w/ tree widget enhancements

Scott Seago sseago at redhat.com
Tue Jan 27 21:58:51 UTC 2009


Jason Guiditta wrote:
> == Create VM/ Storage Flow ==
>   * Can add as many storage volumes as you need to, flow allows you to
> return to secondary form w/o limits.
>   * Create VM form, along with its state and state of tree are stored in
> a temporary area and returned after create storage via pub/sub.
>
> == Tree enhancements ==
>   * Now stores state of selected (open) nodes, so if we have a need to
> reload or generate a new tree with certain nodes open, we now can.
>   * Has ability to subscribe to messages via the 'channel' option
>   * Added refresh method, which can be triggered by a message or fired
> manually.
>   * Refresh adds newly returned items to tree, stubs in place for update
> and delete.
>   * Added lookup object with references to all items in the tree to
> allow for easy recreation of tree w/o another call to server.
>   * Added ui_parent and ui_object references (generated in model via a
> convenience method) to simplify finding nodes to update/add/delete.
>   * Changed click behavior to use event delegation, which means we no
> longer need to use livequery, which scans the dom for changes.  Event
> delegation is much faster and cleaner (can remove livequery entirely
> once all trees use widget).
>
> == Widget tests/files ==
>  *  Adds the standard_tree (actual widget vs nav) test harness
>  *  Cleans up the tree.rhtml to account for some previous restructuring
>  *  Moves sample json data into a 'test' subfolder.
>
> I am looking into some more proper javascript testing systems, so this
> will undoubtedly be changing again in the near future.
>   
OK this works fine for me now except for the cacheContent issue we both 
ran into.
ACK assuming you add that fix to the patch too.

Scott




More information about the ovirt-devel mailing list