[Ovirt-devel] [PATCH node-image] Only lock root account for production builds. For non-release builds leave it open

[Perry Myers]

Jeremy Katz wrote:
> On Jan 29, 2009, at 7:50 PM, Perry Myers <pmyers at redhat.com> wrote:
> 
>> This makes it easier for developers to do work
> 
> This looks pretty fragile as the version of a -release package changes 
> over time. Why not instead have it be more explicit as to whether or not 
> the image is "devel" mode and then key off of that either with different 
> snippets or based on something that's actually set in the image

We have set our build scripts so that a release number of 0 (i.e. 
indicating a pre-release RPM) indicates that the package is a developer build.

In our makefile we have:

> # For Release: 0..., set _ovirt_dev=1 so that we get extra_release.GIT-
> # annotated rpm version strings.
> _ovirt_dev = \
>  $(shell grep -q '^[[:space:]]*Release:[[:space:]]*0' \
>    $(srcdir)/*.spec.in && echo 1 || :)

This causes the following to happen:

> GIT_RELEASE = $(shell date --utc +%Y%m%d%H%M%S)git$(git_head)
> RPM_FLAGS  += $(if $(_ovirt_dev),--define "extra_release .$(GIT_RELEASE)")

This is how we tag development builds using the git hash and timestamp.

So only when the spec.in file has Release: 0 in it will a 'develpment' 
build occur.

My understanding for the Release field is that the convention is for 
production builds the field must be > 0

So not sure how this would be considered fragile?

Perry