[Ovirt-devel] [PATCH node-image] Only lock root account for production builds. For non-release builds leave it open

[Jeremy Katz]

On Friday, January 30 2009, David Lutterkort said:

> On Thu, 2009-01-29 at 22:30 -0500, Jeremy Katz wrote:
> > There's not any definitive way.  What's done in anaconda, for example,
> > is to set BETANAG in /usr/lib/anaconda/constants.py.  Other apps end up
> > using compile-time definitions.  For something like the node, I'd
> > probably lean towards a sysconfig file (/etc/ovirt-node.cfg or similar)
> > and just set shell variable style variables like DEVMODE=1 or yes or
> > similar.  That way it's very clear what's going on and people can
> > trivially toggle it accordingly in their own builds
> 
> That seems like overkill - we don't really need to dynamically switch
> between dev and prod modes.
> 
> How about every developer sticks a '%ovirt_devel_mode 1' into their
> ~/.rpmmacros, and we include some really gross file
> like /THIS-IS-AN-OVIRT-DEV-BUILD in ovirt-node when %ovirt_devel_node is
> set ?

They're fundamentally the same thing.  One just uses a file that's in an
FHS-appropriate location, the other ignores the FHS completely :-)

Well, also, having a config file means that over time as there are other
things that come up that matter and which may want to be configured
already have a place to go.

Jeremy