[Ovirt-devel] Re: [PATCH node] Follow on patch for bz#507393.

[Darryl L. Pierce]

On Thu, Jul 09, 2009 at 12:36:11PM +0200, Alan Pevec wrote:
> Darryl L. Pierce wrote:
>> This patch adds a warning to the NTP changes.
>
> this looks good, just few things need to be amended:
>
>>  function configure_dns
>
>> +                echo "Enter up to two DNS servers separated by commas:"
>
> Isn't that changed to input one per line as for NTP?

It is. 

>
>> +                read -ep "Is this correct (Y/N/A)? "
>
> should use ask_yes_or_no

Fixed.

>
>> @@ -251,13 +263,23 @@ function configure_ntp
>
>> +        if has_configured_interface true; then
>
>> +            while true; do
>> +                read -ep "By continuing, you will remove any existing NTP settings. Continue (y/n)? "
> drop this additional warning, top-level "Configuring the network will destroy any existing networking" is enough

Okay.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Virtual Machine Management - http://www.ovirt.org/
Is fearr Gaeilge bhriste ná Béarla cliste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20090709/5ee2d9d1/attachment.sig>