[Ovirt-devel] [PATCH] updated viewer spec to make it fedora rpm guidelines compliant

[Mohammed Morsi]

---
 ovirt-viewer.spec |   25 ++++++++++++++++---------
 1 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/ovirt-viewer.spec b/ovirt-viewer.spec
index 1db5994..28b6357 100644
--- a/ovirt-viewer.spec
+++ b/ovirt-viewer.spec
@@ -1,9 +1,7 @@
-%define pbuild %{_builddir}/%{name}-%{version}
-
 Name: ovirt-viewer
 Version: 1.0.0
-Release: 4%{?dist}
-Summary: ovirt-viewer is a vnc viewer for ovirt managed vms
+Release: 5%{?dist}
+Summary: A vnc viewer for oVirt managed vms
 
 Group: Applications/System
 License: GPLv2+
@@ -24,12 +22,10 @@ BuildRequires: libxml2-devel
 BuildRequires: gnutls-devel
 BuildRequires: libcurl-devel
 BuildRequires: glib2-devel
+BuildRequires: /usr/bin/pod2man
 Requires: gtk2
 Requires: gtk-vnc
-Requires: libxml2
 Requires: gnutls
-Requires: libcurl
-Requires: glib2
 
 
 %description
@@ -46,12 +42,17 @@ allows the users to seemlessly switch between managed vms via ui.
 %build
 ./autogen.sh
 ./configure
-make %{?_smp_mflags}
+
+export CFLAGS="$RPM_OPT_FLAGS"
+export CXXFLAGS="$RPM_OPT_FLAGS"
+make %{?_smp_mflags} CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS"
+%{__gzip} man/ovirt-viewer.1
 
 %install
 rm -rf $RPM_BUILD_ROOT
 
-%{__install} -Dp -m0755 %{pbuild}/src/ovirt-viewer %{buildroot}%{_bindir}/ovirt-viewer
+%{__install} -Dp -m0755 src/ovirt-viewer %{buildroot}%{_bindir}/ovirt-viewer
+%{__install} -Dp -m0644 man/ovirt-viewer.1.gz %{buildroot}%{_mandir}/man1/ovirt-viewer.1.gz
 
 %clean
 rm -rf $RPM_BUILD_ROOT
@@ -59,8 +60,14 @@ rm -rf $RPM_BUILD_ROOT
 %files
 %defattr(-,root,root,-)
 %{_bindir}/ovirt-viewer
+%{_mandir}/man1/ovirt-viewer.1.gz
 
 %changelog
+* Thu Jul  23 2009  <mmorsi at redhat.com> - 1.0.0-5
+- various fixes to make this, rpmlint and
+  guidelines compliant
+- added man page installation
+
 * Mon Jun  01 2009  <mmorsi at redhat.com> - 1.0.0-4
 - bugfixes, dns lookup and local tunnel port assignment
 
-- 
1.6.0.6