[Ovirt-devel] Re: [PATCH server] fixes to the multiple vm/nets component

Jason Guiditta jguiditt at redhat.com
Fri Jul 31 15:28:36 UTC 2009


On Thu, 2009-07-30 at 16:05 -0400, Mohammed Morsi wrote:
> - changes to the form/style cleaning it up greatly
>  - changes to the controller fixing allowing nics/
>     networks to actually be saved (credit to Michel
>     Loiseleur for helping with this)
>  - very small test and indentation fixes
> ---
>  src/app/controllers/vm_controller.rb      |   41 +++-
>  src/app/views/vm/_form.rhtml              |  365 ++++++++++++++---------------
>  src/public/stylesheets/components.css     |   32 ++-
>  src/test/functional/vm_controller_test.rb |    1 -
>  4 files changed, 231 insertions(+), 208 deletions(-)
> 
ACK, I can now save multiple networks successfully, and they are
correctly written to the libvirt xml.  However, we will need to do a
follow-up patch to handle form errors properly - errors are returned,
but not hooked to the form atm.





More information about the ovirt-devel mailing list