[Ovirt-devel] Re: [PATCH server] improvements / fixes to ovirt network ui

[Mohammed Morsi]

Jason Guiditta wrote:
> On Tue, 2009-03-03 at 14:07 -0500, Mohammed Morsi wrote:
>   
>> Patch bump. Know everyone's busy w/ the installer and other things but
>> was wondering if anyone had a second to take a look at this before it
>> got stale.
>>
>> I made sure to thoroughly test everything included when I wrote it so a
>> brief code review and a quick functionality verification should be all
>> that's needed.
>>
>> I had also sent out an additional email with a few notes relating to
>> these changes. It can be found here
>> https://www.redhat.com/archives/ovirt-devel/2009-February/msg00178.html
>>
>> Thanks alot,
>>    -Mo
>>     
>
> I think this is close to ok, with a few caveats Mo and I discussed in
> irc as I was testing:
>   
Just sent an updated patch addressing these issues:

> * Migration needs to handle setting some fields to null, so they dont
> break constraints when running migration
> * There is a form error mo is going to look into
> * Networks dropdown in New VM does not default to blank
>   

The following two issues rebrings up a requirements question previously
asked. The concern is that when starting a vm, an interface name must be
specified for it to use, which must be deduced from the network ui. An
exception to this rule would be when the vm is being booted of a hard
drive, in which case its presumed a network connection isn't necessary
and thus does not need to be specified. In the case of PXE and cobbler
boots, the ui and model will require a user to specify a network to be
associated with the vm, and when the vm is being started, it iis
necessary for a nic / bonding to exist on node which will be hosting the
vm and associated with the network the user selected for that vm.
Otherwise the vm will fail to start with an error message. I just wanted
to reraise this point again and make sure that this is the required
functionally.

>
> On 'vm create / edit form'
> * upon submitting the form, if the 'boot type' is not 'hd', a network
> _must_ be selected (we need to confirm w/ Hugh that this requirement is
> ok)
>
> When starting a vm:
> * If the vm's boot type is not marked as 'hd' and there is no nic or
> bonding on the host that is to run the vm, that is associated with the
> network the user selected (on the vm create / edit form), the start
> operation fails (also need confirmation w/ Hugh on this one). Note if a
> user selected a physical network for the vm, only nics on the host will
> be checked, and if a vlan is selected for the vm, only bondings on the
> host will be checked (to see if they are on the selected network)
>
>   

    -Mo