[Ovirt-devel] [PATCH server webui] Change the "Edit virtual machine" to "Save settings" button]

Hugh O. Brock hbrock at redhat.com
Wed May 13 14:24:51 UTC 2009


On Tue, May 12, 2009 at 11:02:23PM +0200, william wrote:
> Now with a git patch!
> 
> and a reply to all ;)
> 
> G William
> 
> On Wed, 2009-04-22 at 21:42 +0200, william wrote:
> > A small change in the Web UI edit virtual machine.
> > 
> > --- app/views/vm/edit.rhtml.orig        2009-04-22 21:18:50.000000000
> > +0200
> > +++ app/views/vm/edit.rhtml     2009-04-22 21:19:11.000000000 +0200
> > @@ -11,7 +11,7 @@
> >      <%= render :partial => 'form', :locals => { :create => false }  %>
> >    </div>
> >    <!-- DIALOG  FOOTER -->
> > -  <%= popup_footer("$('#vm_form').submit()", "Edit Virtual Machine") %>
> > +  <%= popup_footer("$('#vm_form').submit()", "Save settings") %>
> >    </form>
> >  
> >  <script type="text/javascript">
> > 
> > 
> > With kind regards
> > 
> > William van de Velde
> > 
> > _______________________________________________
> > Ovirt-devel mailing list
> > Ovirt-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/ovirt-devel

Anyone have any objections to this patch? To be honest, I've always
found the labeling on that button confusing as well. Jeremy Perry, your
thoughts?

--Hugh




More information about the ovirt-devel mailing list