[Ovirt-devel] Re: [PATCH node] Adds support for a core dump partition to the node.

[Alan Pevec]

Darryl L. Pierce wrote:
> If a /data partition is created, then a subdirectory is created,
> /data/cores. This directory is then bindmounted along with /data.

should be /var/log/core/ and /data/core/

> @@ -398,7 +398,9 @@ perform_partitioning()
>          tune2fs -c 0 -i 0 /dev/HostVG/Data
>          echo "/dev/HostVG/Data /data ext3 defaults 0 0" >> /etc/fstab
>          echo "/data/images /var/lib/libvirt/images bind bind 0 0" >> /etc/fstab
> +	echo "/data/cores /var/log/cores bind bind 0 0" >> /etc/fstab

please use spaces not TABs

>          log "Mounting data partition"
> +	mkdir -p /var/log/cores
this will end up on tmpfs and if there's logging partition, mount_logging will hide it.
mount_data should come after mount_logging

updated patch follows