[Ovirt-devel] [PATCH server] Updated look and feel for empty grid views

Jason Guiditta jguiditt at redhat.com
Fri May 22 01:27:08 UTC 2009


On Thu, 2009-05-21 at 10:38 -0400, Jeremy Perry wrote:
> When empty grids are shown (ex: no VMs in this pool) a specific graphic, message and improved action button are shown. For Task views, the user will see the current filter and an explanation that no tasks match that filter.
> 
> Signed-off-by: Jeremy Perry <jeremy.perry at redhat.com>
> ---
>  src/app/views/hardware/show_hosts.rhtml      |   11 ++++-------
>  src/app/views/hardware/show_storage.rhtml    |   15 ++++++---------
>  src/app/views/hardware/show_vms.rhtml        |   17 +++++++----------
>  src/app/views/network/list.html.erb          |    9 ++++-----
>  src/app/views/resources/show_vms.rhtml       |   25 +++++++++++--------------
>  src/app/views/search/results.rhtml           |    4 ++--
>  src/app/views/smart_pools/show_hosts.rhtml   |    9 ++++-----
>  src/app/views/smart_pools/show_pools.rhtml   |    9 ++++-----
>  src/app/views/smart_pools/show_storage.rhtml |    9 ++++-----
>  src/app/views/smart_pools/show_vms.rhtml     |    9 ++++-----
>  src/app/views/task/_show.rhtml               |   19 +++++++++++--------
>  src/app/views/user/_show.rhtml               |    7 ++++---
>  src/public/images/no-grid-items.png          |  Bin 15004 -> 0 bytes
>  src/public/stylesheets/components.css        |   25 ++++++++++++++++++++++---
>  14 files changed, 87 insertions(+), 81 deletions(-)
>  delete mode 100644 src/public/images/no-grid-items.png

ACK and pushed, looks much nicer.  Only minor nit is standard html img
tags replaced rails image_tag helpers, but not sure I feel that stringly
one way or the other.  We can always adjust later.

-j




More information about the ovirt-devel mailing list