[Ovirt-devel] [PATCH node] prevent indefinite loop in o-c-storage

Alan Pevec apevec at redhat.com
Thu May 28 10:28:33 UTC 2009


From: Joey Boggs <jboggs at redhat.com>

by allowing "q" to abort
---
 scripts/ovirt-config-storage |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index cc9248b..356b7df 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -218,11 +218,14 @@ do_configure()
 
         while true; do
             printf "\n"
-            read -ep "Change $part partition size. (Def. ${size}MB), Min. ${min_size}MB, Max. ~${space_left}MB? "
+            read -ep "Change $part partition size. (Def. ${size}MB), Min. ${min_size}MB, Max. ~${space_left}MB? or Q to quit "
             mb_input=$REPLY
             test -z "$mb_input" && mb_input=$size
             local size_used=0
-            if [[ $mb_input =~ ^-*[0-9]+$ ]]; then
+            if [[ $mb_input == "q" || $mb_input == "Q" ]]; then
+                printf "Aborting"
+                return
+            elif [[ $mb_input =~ ^-*[0-9]+$ ]]; then
                 if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp ]] \
                     && [[ $mb_input -le $space_left ]] ; then
                     eval "$size_var=$mb_input"
-- 
1.6.0.6




More information about the ovirt-devel mailing list