[Ovirt-devel] [PATCH node] correctly use collectd udp dns entry

Scott Seago sseago at redhat.com
Fri May 29 01:28:30 UTC 2009


Jason Guiditta wrote:
> I dont have a strong opinion here either, though I have been putting 
> bz # in subject, and I think scott has been doing the same.  Makes it 
> easy for me on review to know that it is a bz patch just looking at my 
> inbox.
>
You could always put both in the subject line. To be honest I'm not 
happy with the way git send-email splits the commit message. I'd rather 
see the first line of the commit message repeated in the body of the 
email -- I should be able to read the body of a message and get all the 
information I need from it, so anything essential from the subject 
should also be in the message.

Scott
> -j
>
> On Thu, May 28, 2009 at 6:27 PM, David Lutterkort <lutter at redhat.com 
> <mailto:lutter at redhat.com>> wrote:
>
>     On Thu, 2009-05-28 at 18:22 -0400, Jason Guiditta wrote:
>     > ACK, though I agree, update subject to have bz, move description
>     into
>     > body
>
>     Not sure if any fixed style for this has been adopted, but I prefer
>     having the bz info in the body of the commit - it's usually not
>     important enough to be needed in the subject; though it's much more
>     important to me that it is preserved somewhere than whether it's
>     in the
>     subject or the body.
>
>     David
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ovirt-devel mailing list
> Ovirt-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/ovirt-devel
>   




More information about the ovirt-devel mailing list