[Ovirt-devel] [PATCH] Provides an explicit upgrade path for an installed node.

[Darryl L. Pierce]

On Fri, Nov 13, 2009 at 10:12:17PM +0100, Alan Pevec wrote:
> On Fri, Nov 13, 2009 at 5:39 PM, Darryl L. Pierce <dpierce at redhat.com> wrote:
> > -            ovirt_local_boot*)
> > -            local_boot=1
> > +            ovirt_upgrade*)
> > +            upgrade=1
> 
> I think it shouldn't hurt to keep old parameter name for compatibility reasons:
> ovirt_local_boot* | ovirt_upgrade*)
> 
> otherwise it looks good, just as a follow patch please add a test case
> in o-n-i autotest.sh - even upgrading to the same version would be a
> good sanity check that upgrade didn't break existing configuration

Very good. I'll have a refactored patch out shortly.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20091116/975f8e9e/attachment.sig>