[Ovirt-devel] taskomatic.rb : set_vm_vnc_port

[Arthur Clément]

Hi,

Does somebody know what is the purpose of this line in taskomatic.rb :

set_vm_vnc_port(db_vm, result.description) unless result.status != 0



We removed it to avoid 2 errors in taskomatic.log when a vm is launched :

ERROR Mon Aug 30 15:23:00 +0000 2010 (26416) Task action processing failed: 
ActiveRecord::RecordInvalid: Validation failed: Vnc port must be greater than 
or equal to 0
ERROR Mon Aug 30 15:23:00 +0000 2010 (26416) 
/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/validations.rb:1090:in 
`save_without_dirty!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/dirty.rb:87:in 
`save_without_transactions!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/transactions.rb:200:in 
`save!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/abstract/database_statements.rb:136:in 
`transaction'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/transactions.rb:182:in 
`transaction'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/transactions.rb:200:in 
`save!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/transactions.rb:208:in 
`rollback_active_record_state!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/transactions.rb:200:in 
`save!'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/associations/association_proxy.rb:217:in 
`send'/usr/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/associations/association_proxy.rb:217:in 
`method_missing'/usr/share/ovirt-server/task-omatic/./task_vm.rb:133:in 
`set_vm_vnc_port'/usr/share/ovirt-server/task-omatic/taskomatic.rb:426:in 
`task_start_vm'/usr/share/ovirt-server/task-omatic/taskomatic.rb:919:in 
`mainloop'/usr/share/ovirt-server/task-omatic/taskomatic.rb:905:in 
`each'/usr/share/ovirt-server/task-omatic/taskomatic.rb:905:in 
`mainloop'/usr/share/ovirt-server/task-omatic/taskomatic.rb:871:in 
`loop'/usr/share/ovirt-server/task-omatic/taskomatic.rb:871:in 
`mainloop'/usr/share/ovirt-server/task-omatic/taskomatic.rb:972
INFO Mon Aug 30 15:23:00 +0000 2010 (26416) done



context :

423     # Reget the db record or you can get 'dirty' errors.  This can happen 
in a number
424     # of places so you'll see a lot of .reloads.
425     db_vm.reload
426     set_vm_vnc_port(db_vm, result.description) unless result.status != 0
427 





-- 
Arthur CLEMENT
Linagora Paris