[Ovirt-devel] [PATCH node] disallow any partitions being set to 0MB

[Joey Boggs]

On 02/11/2010 12:33 PM, Ryan Harper wrote:
> * Joey Boggs<jboggs at redhat.com>  [2010-02-11 10:26]:
>    
>> ---
>>   scripts/ovirt-config-storage |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
>> index 9c3f773..10a4066 100755
>> --- a/scripts/ovirt-config-storage
>> +++ b/scripts/ovirt-config-storage
>> @@ -291,7 +291,7 @@ EOF
>>                   printf "Aborting"
>>                   return
>>               elif [[ $mb_input =~ ^-*[0-9]+$ ]]; then
>> -                if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp ]] \
>> +                if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp&&  $mb_input -ne 0 ]] \
>>      
> Does this prevent someone setting the SWAP partition to zero?  For
> example if someone doesn't want to enable overcommit is there a
> requirement for having an active SWAP partition?
>
>    
It would, but patch is being nak'ed so no worries