[Ovirt-devel] [PATCH] Allow persistance of empty config files in ovirt_store_config

Darryl L. Pierce dpierce at redhat.com
Thu Mar 25 17:04:22 UTC 2010


On Thu, Mar 25, 2010 at 01:49:56PM -0300, Ricardo Marin Matinata wrote:
> On Thu, 2010-03-25 at 14:28 +0100, Alan Pevec wrote:
> > On Thu, Mar 25, 2010 at 1:41 PM, Darryl L. Pierce <dpierce at redhat.com> wrote:
> > >>                  # skip if file does not exist or is empty
> > if changing logic, comments...
> > 
> > >> -                if [ ! -s "${filename}" ]; then
> > >> +                if [ ! -e "${filename}" ]; then
> > >>                      printf " Skipping, file '${filename}' does not exist or is empty\n"
> > ... and messages should be corrected
> > 
> > >>                      continue
> > >>                  fi
> 
> Agree... Re-sending below just in case...
> 
> > 
> 
> This fix enables the persistence of empty configuration files during
> firstboot, in ovirt_store_config, so configuration files like ssh/ssl
> keys that are dynamically generated (i.e. content is not known until the
> node has booted at least one time) to well known locations can be pre
> set for persistence.

Can you resend the patch by itself so that it doesn't get reformated?
Thanks. :)

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20100325/eae1f8e9/attachment.sig>


More information about the ovirt-devel mailing list