[Ovirt-devel] [PATCH node] save all not-parsed boot parameters

[Ricardo Marin Matinata]

I think this patch is really useful, specially towards automated PXE
installations. I do have, however, one comment below with regard to
escaping typical boot parameters, not intended to be passed-on to the
final installed node...

On Wed, 2010-05-05 at 00:27 +0200, Alan Pevec wrote:
> not just console=
> This is to allow vendor-specific boot parameters to survive when the
> image is installed to disk.
> 
> Signed-off-by: Alan Pevec <apevec at redhat.com>
> ---
>  scripts/ovirt-early |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/ovirt-early b/scripts/ovirt-early
> index 4b85102..c17ea74 100755
> --- a/scripts/ovirt-early
> +++ b/scripts/ovirt-early
> @@ -426,13 +426,13 @@ start_ovirt_early () {
>              i=${i#collectd=}
>              eval $(printf $i|awk -F: '{print "collectd_server="$1; print "collectd_port="$2;}')
>              ;;
> -            console=*)
> -            bootparams="$bootparams $i"
> -            ;;
>              ovirt_early=*)
>              i=${i#ovirt_early=}
>              ovirt_early=$(echo $i|tr ",:;" " ")
>              ;;

+	      root=*|BOOT_IMAGE=*|rootfstype=*|initrd=*|check|rootflags=*|ro|
linux|liveimg)
+ 	      ;;

> +            *)
> +            bootparams="$bootparams $i"
> +            ;;
>          esac
>      done
>  

-- 
Ricardo Marin Matinata
Linux Technology Center
IBM Brazil | Hortolandia | SP
matinata br ibm com