[Ovirt-devel] [Matahari] [PATCH matahari] Introduces explicit heartbeat events to the QMF transport.

[Darryl L. Pierce]

On Thu, May 27, 2010 at 08:43:30AM +0200, Andrew Beekhof wrote:
> >> Does the heartbeat event need a counter (like ICMP packets do) to
> >> detect backward jumps and/or lost heartbeats?
> > 
> > Right now the heartbeat sends out the timestamp. But if the clock gets changed, it
> > could seem to be a backwards jump. Changing it to be a counter instead would
> > be a simple change to this patch for pushing.
> 
> I think you'd probably want both.  The timestamp and a sequence number.

That's cool. Okay, so if this is an ACK with that change (I'll wait for
a response) I'll go ahead and push it.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20100527/2417cf83/attachment.sig>