<br><br><div class="gmail_quote">On Thu, Jan 15, 2009 at 9:21 AM, Itamar Heim <span dir="ltr"><<a href="mailto:iheim@redhat.com">iheim@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> From: <a href="mailto:ovirt-devel-bounces@redhat.com">ovirt-devel-bounces@redhat.com</a> [mailto:<a href="mailto:ovirt-devel-">ovirt-devel-</a><br>
> <a href="mailto:bounces@redhat.com">bounces@redhat.com</a>] On Behalf Of Darryl L. Pierce<br>
<div class="Ih2E3d">><br>
> NOTE: this version removes the upper limit on swap size and only uses<br>
> the calculated value if no size was specified.<br>
</div>[IH] I assume it can't be larger than (<actual disk size>-<min space of<br>
other partitions>)?<br>
do we fail in such a case, or do we auto adjust the swap size?<br>
</blockquote><div><br>It would fail somewhere later: Swap LV is created first, then Root, Config and Logging and finally the rest of PV is allocated to Data LV.<br>Sanity checks and error recovery are not implemented, there's FIXME comment in check_partition_sizes():<br>
<br><blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote"> # FIXME: use this function before performing any partitioning, auto or not<br> :<br>
# Perform some sanity checks. E.g.,<br> # What if DATA_SIZE ends up zero or negative?</blockquote><div> <br>DATA_SIZE is not calculated, so Data LV creation with 100%FREE would fail<br><br></div><blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">
# What if any of those partition sizes is smaller than<br> # the minimum size for an ext3 partition? Diagnose it here<br> # or just let the mke2fs failure suffice.<br></blockquote><br></div></div>let mke2fs fail, but error conditions must be clearly reported. Currently perform_partitioning() has set -e and stops silently on any failure.<br>
<br>To summarize, error recovery or sanity checks are not worth the effort IMO, but we need to improve error and progress report (currently all output goes to both logfile and console).<br><br>