ACK, this works fine for me, one comment inline<br><br><div class="gmail_quote">On Tue, May 19, 2009 at 10:23 AM, Scott Seago <span dir="ltr"><<a href="mailto:sseago@redhat.com">sseago@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Signed-off-by: Scott Seago <<a href="mailto:sseago@redhat.com">sseago@redhat.com</a>><br>
---<br>
src/app/controllers/resources_controller.rb | 2 +-<br>
src/app/controllers/vm_controller.rb | 2 +-<br>
2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/app/controllers/resources_controller.rb b/src/app/controllers/resources_controller.rb<br>
index bf2a234..6990df7 100644<br>
--- a/src/app/controllers/resources_controller.rb<br>
+++ b/src/app/controllers/resources_controller.rb<br>
@@ -90,7 +90,7 @@ class ResourcesController < PoolController<br>
raise PartialSuccessError.new("Delete failed for some VM Pools",<br>
failures, successes)<br>
end<br>
- render :json => { :object => "vm_resource_pool", :success => success,<br>
+ render :json => { :object => "vm_resource_pool", :success => true,<br>
:alert => "VM Pools were successfully deleted." }<br>
end<br>
<br>
diff --git a/src/app/controllers/vm_controller.rb b/src/app/controllers/vm_controller.rb<br>
index e918ae7..b51f4ae 100644<br>
--- a/src/app/controllers/vm_controller.rb<br>
+++ b/src/app/controllers/vm_controller.rb<br>
@@ -104,7 +104,7 @@ class VmController < ApplicationController<br>
raise PartialSuccessError.new("Delete failed for some VMs",<br>
failures, successes)<br>
end<br>
- render :json => { :object => "vm", :success => success,<br>
+ render :json => { :object => "vm", :success => true,<br>
:alert => "VM Pools were successfully deleted." }</blockquote><div>This ^^ seems like it should be 'Virtual Machines' rather then 'VM Pools'. Could you fix that before pushing? If not, maybe we can fix it in a separate one.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
end<br>
<font color="#888888"><br>
--<br>
1.6.0.6<br>
<br>
_______________________________________________<br>
Ovirt-devel mailing list<br>
<a href="mailto:Ovirt-devel@redhat.com">Ovirt-devel@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/ovirt-devel" target="_blank">https://www.redhat.com/mailman/listinfo/ovirt-devel</a><br>
</font></blockquote></div><br>