[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: patch for pam_unix



On Tue, 28 Dec 1999, Steve Langasek wrote:

> On Tue, 28 Dec 1999, Steve Langasek wrote:
> 
> >On Tue, 28 Dec 1999, Nalin Dahyabhai wrote:
> >> Hi, I found a problem with the new pam_unix's handling of the "unixlike"
> >> argument that appears to break it.  I've attached a patch.
> 
> >This patch depends on an int and a pointer being the same size, which is a
> >non-portable assumption.
> 
> >The correct solution is to malloc() the space for the return value, and pass
> >its address to pam_set_data().  The pam_sm_setcred() function is then
> >responsible for freeing the data when it's done with it.
> 
> > I'll pull together a patch later today that does this.
> 
> And here's the patch.  I can't believe the code that was in there slipped
> through--it clearly doesn't even come close to the desired behavior. <smacking
> forehead> :)

This is strange :o I wrote that code, tested it and it worked.  But shouldn't.
Your patch looks good to me.

Jan
-- 
Jan RÍkorajski            |  ALL SUSPECTS ARE GUILTY. PERIOD!
baggins<at>mimuw.edu.pl   |  OTHERWISE THEY WOULDN'T BE SUSPECTS, WOULD THEY?
BOFH, type MANIAC         |                   -- TROOPS by Kevin Rubio



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index] []