[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: patch for pam_unix



On Tue, Dec 28, 1999 at 12:10:55PM -0600, Steve Langasek wrote:
> On Tue, 28 Dec 1999, Steve Langasek wrote:
> 
> >On Tue, 28 Dec 1999, Nalin Dahyabhai wrote:
> >> Hi, I found a problem with the new pam_unix's handling of the "unixlike"
> >> argument that appears to break it.  I've attached a patch.
> 
> >This patch depends on an int and a pointer being the same size, which is a
> >non-portable assumption.
> 
> > I'll pull together a patch later today that does this.
> 
> And here's the patch.  I can't believe the code that was in there slipped
> through--it clearly doesn't even come close to the desired behavior. <smacking
> forehead> :)
> 
> Nalin, can you please confirm that this patch exhibits the correct behavior?
> I don't have any machines which depend on the return code that I can use to
> test it (which is probably why it escaped my notice :).  Thanks. :)

Looks good from here.  Probably need to add something like
if(ret_data == NULL)
	return PAM_BUF_ERR;
around line 113, but it still works just fine.

Thanks,

Nalin



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index] []