[linux-pam] pam_pwhistory: lose a reinitialization

[Wang Weidong]

On 2014/5/7 19:32, Tomas Mraz wrote:
> On St, 2014-05-07 at 10:08 +0800, Wang Weidong wrote:
>> Hi Tomas,
>>
>> On Linux-PAM-1.1.6, I do 'make xtests' get a FAIL (tst-pam_history1).
>>
>> As commit 585f6c06b2d3574935ed62c3084f2aadd6d1defb("pam_pwhistory: Always record the
>> old password even when root changes it."), maybe here we lose a reinitialization
>> for newpass in pam_sm_chauthtok.
>>
>> As commit bd07ad3adc626f842a4391d256541883426fd389("Reflect the enforce_for_root 
>> semantics change in pam_pwhistory xtest."), add an option 'enforce_for_root' can
>> make the 'tst-pam_history1' PASS.
>>
>> What do you think?
> 
> The actual fix is the commit bd07ad3adc626f842a4391d256541883426fd389 .
> Your patch would break the default behavior for root which is to just
> warn that the password was already used but it allows the change anyway.
> 

Got it.

Thanks
Wang

> Regards,
>