[Patchew-devel] [PATCH v2] Text to json convertor for mbox

[Paolo Bonzini]

On 27/04/2018 18:10, Shubham Jain wrote:
> 
> 
> On Fri, Apr 27, 2018 at 9:35 PM Paolo Bonzini <pbonzini at redhat.com
> <mailto:pbonzini at redhat.com>> wrote:
> 
>     On 27/04/2018 14:32, Shubham Jain wrote:
>     >
>     >
>     > On Fri, Apr 27, 2018 at 5:37 PM Paolo Bonzini <pbonzini at redhat.com
>     <mailto:pbonzini at redhat.com>
>     > <mailto:pbonzini at redhat.com <mailto:pbonzini at redhat.com>>> wrote:
>     >
>     >     Very good progress, thanks!
>     >
>     >     On 27/04/2018 13:53, Shubham Jain wrote:
>     >     >  class BaseMessageViewSet(mixins.ListModelMixin,
>     >     viewsets.GenericViewSet):
>     >     > @@ -285,7 +285,8 @@ class
>     >     ProjectSeriesViewSet(ProjectMessagesViewSetMixin,
>     >     >  class MessageSerializer(BaseMessageSerializer):
>     >     >      class Meta:
>     >     >          model = Message
>     >     > -        fields = BaseMessageSerializer.Meta.fields + ('mbox', )
>     >     > +        # fields = BaseMessageSerializer.Meta.fields +
>     ('mbox', )
>     >     > +        fields = '__all__'
>     >
>     >     What is fields = '__all__'? :)
>     >
>     > Since you mentioned to use browsable api "form" to check for POST. The
>     > "__all__" helps to get all the fields in the model. This would
>     help with
>     > the fields which were dependent on mbox since we are not providing any
>     > mbox.
> 
>     Ok, one thing at a time.  First of all let's apply the mbox.py and
>     tests/test_mbox.py parts.  That's ready except that msg['mbox'] should
>     be populated as well.
> 
> Why should be mbox populated? Aren't we trying to convert the content in
> mbox from text to son?

Yes, but the mbox can be re-exported so it is stored in the database.

>     I placed a checklist for this at
>     https://github.com/patchew-project/patchew/issues/75.  Each item can be
>     a separate patch.  If you have a GitHub account we can give you edit
>     access.
> 
> My GitHub handle is shubhamdotjain 

Ah no, I cannot.  Fam, I would like to add Shubham to the
patchew-project github organization at least during summer of code.  Do
you agree?

Thanks,

Paolo