[Patchew-devel] [PATCH 3/4] testing: Don't reset all tests upon git result update
Fam Zheng
famz at redhat.com
Thu Aug 2 08:35:13 UTC 2018
On Thu, 08/02 10:24, Paolo Bonzini wrote:
> On 02/08/2018 10:14, Fam Zheng wrote:
> > Git results move to "PENDING" to get applier redo the apply if replies
> > have added "reviewed-by" tags etc. The testing mod's event handler
> > on_result_update cannot tell if this is only adding tags, in which case
> > re-test is not necessary and may result in duplicated error reports.
> >
> > Instead, subscribe to TagsUpdate event and handle "Based-on:" tag
> > specifically.
>
> What about keeping ResultUpdate, but checking the base from the git
> result against the base from the testing result? Well, there is no base
> from the testing result but there should be one...
Yes, this sounds good to me.
Fam
More information about the Patchew-devel
mailing list