[Patchew-devel] [PATCH v2 3/3] Make Import Command use Rest

Paolo Bonzini pbonzini at redhat.com
Tue Jul 3 08:40:32 UTC 2018


On 03/07/2018 10:36, Fam Zheng wrote:
> On Tue, 07/03 13:41, Shubham Jain wrote:
>> On importing a message which is already imported before, the REST would
>> give error UNIQUE constraint failed: api_message.project_id,
>> api_message.message_id.
> 
> This breaks scripts/patchew-impoter. Upon network error, the importer instance
> is restarted and will retry the import. The server may already received the
> message but just failed to return to patchew-cli, in this case, an empty
> project_list makes more sense than error.
> 
> The UNIQUE contraint error should only apply to explicit project list when
> import. From a user perspective, if I submit a message and rely on the server to
> figure out which projects to add it, I don't think such an error is reasonable,
> even if it has been imported before.

Shubham, can you create a github issue for this?

Thanks,

Paolo




More information about the Patchew-devel mailing list