[Patchew-devel] [PATCH 01/10] testing: Avoid masking out outter iterator r

Fam Zheng famz at redhat.com
Thu Jul 26 08:24:48 UTC 2018


On Thu, Jul 26, 2018 at 4:23 PM Paolo Bonzini <pbonzini at redhat.com> wrote:
>
> On 26/07/2018 03:47, Fam Zheng wrote:
> > The 'r' we want to yield is the object in queryset. Avoid overwriting it
> > with a requirement string.
> >
> > Signed-off-by: Fam Zheng <famz at redhat.com>
> > ---
> >  mods/testing.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Did the unit tests miss this, because they never use requirements?

Good point! Will improve tests.

Fam

>
> Thanks,
>
> Paolo




More information about the Patchew-devel mailing list