[Patchew-devel] [PATCH] Make Patchew cli use rest api

[Fam Zheng]

On Mon, 06/25 14:13, Paolo Bonzini wrote:
> On 25/06/2018 14:06, Shubham Jain wrote:
> > - Disabled CSRF authentication until OAuth authentication, since DRF leads to csrf error while handling sessionauthentication.
> > - Added general rest_api function to make request to apis and get response.
> > - Make project functions use the rest_api_do instead of api_do
> 
> Thanks.
> 
> CSRF cannot really be removed before we have some kind of token-based
> authentication, either TokenAuthentication or OAUTH, so this part of the
> project needs to be developed in a branch.  I still prefer not to delay
> this part because it's really telling us if the REST API works or not.
> 
> Fam, how would you prefer to handle the branching?  We cannot change
> patchew-cli until patchew.org has the REST API; and I would like to have
> my "result" table patches before we branch, since they seem to be
> stable, but before that we need to test migration on patchew.org (not
> just next.patchew.org).  I can think of two strategies:
> 
> 1) branch "next" now, then apply the "result" table patches to both
> master and next
> 
> 2) Shubham works into a branch that is neither master nor next, and we
> apply his patches only after token-based authentication is done.
> 
> What do you prefer?

I was in LinuxCon in the past week, sorry for days of delay.

In the future I'm inclined to have patchew.org track master and next.patchew.org
track the next branch, which is even a better alignment in names. How about
this?

1) branch next now
2) point next.patchew.org to it
3) apply your result table patches and Shubham's patchew-cli patches to next
4) more tests on master, then deploy to patchew.org
5) figure out a workflow between next and master (i.e. next.patchew.org and
   patchew.org)

4) and 5) can be worked on at the same time.

Fam